topology pgsql 10 regression failures

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

topology pgsql 10 regression failures

Paul Ramsey-3
Several failures for me (Darwin Kernel Version 15.6.0) right now in topology, for example, 

regress/st_simplify .. failed (diff expected obtained: /tmp/pgis_reg/test_26_diff)

This "invalid geometry type" shows up in a few of the other failures further down. Anyone seeing similar things w/ pgsql 10? 

--- regress/st_simplify_expected    2014-12-01 12:28:41.000000000 -0800
+++ /tmp/pgis_reg/test_26_out   2017-05-26 08:02:22.000000000 -0700
@@ -1,9 +1,8 @@
 t
 L1
-N2
-S1|f|t
-S2|f|t
+ERROR:  Invalid geometry type (POLYGON) passed to TopoGeo_AddLinestring, expected LINESTRING
+N1
+S1|f|
+S2|f|
 L2
-HS1|f|t
-HS2|f|t
 f


_______________________________________________
postgis-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/postgis-devel
Reply | Threaded
Open this post in threaded view
|

Re: topology pgsql 10 regression failures

Regina Obe-2

I beat you to it J

 

https://trac.osgeo.org/postgis/ticket/3764

 

I'll try to fix when I get the chance.

 

BTW: For this error, are you seeing this one?

 

https://trac.osgeo.org/postgis/ticket/3759

 

 

/tmp/2.4.0dev_pg10_geos3.7.0dev_gdal2.1.3w64/test_89_diff)

-----------------------------------------------------------------------------

--- tickets_expected   2016-09-26 01:59:38 -0400

+++ /projects/postgis/tmp/2.4.0dev_pg10_geos3.7.0dev_gdal2.1.3w64/test_89_out        2017-05-25 15:15:09 -0400

@@ -285,7 +285,7 @@

#3375|GEOMETRYCOLLECTION(POINT(0 -7))

#3399|1|1

#3399|10|10

-#3399|100|100

+#3399|100|99

#3399|1000|1000

ERROR:  invalid KML representation

#3437a|5

-----------------------------------------------------------------------------

 

 

Do we go with float or float4.  If float4, I think you need to change the regression and also the pre-10 code.

 

the geometry regression in tickets caused by this change

 nd_stats = palloc(sizeof(float) * sslot.nnumbers);
 memcpy(nd_stats, sslot.numbers, sizeof(float) * sslot.nnumbers);

To:

 nd_stats = palloc(sizeof(float4) * sslot.nnumbers);
 memcpy(nd_stats, sslot.numbers, sizeof(float4) * sslot.nnumbers);

 

 

Thanks,

Regina

 

 

From: postgis-devel [mailto:[hidden email]] On Behalf Of Paul Ramsey
Sent: Friday, May 26, 2017 11:13 AM
To: PostGIS Development Discussion <[hidden email]>
Subject: [postgis-devel] topology pgsql 10 regression failures

 

Several failures for me (Darwin Kernel Version 15.6.0) right now in topology, for example, 

 

regress/st_simplify .. failed (diff expected obtained: /tmp/pgis_reg/test_26_diff)

 

This "invalid geometry type" shows up in a few of the other failures further down. Anyone seeing similar things w/ pgsql 10? 

 

--- regress/st_simplify_expected    2014-12-01 12:28:41.000000000 -0800

+++ /tmp/pgis_reg/test_26_out   2017-05-26 08:02:22.000000000 -0700

@@ -1,9 +1,8 @@

 t

 L1

-N2

-S1|f|t

-S2|f|t

+ERROR:  Invalid geometry type (POLYGON) passed to TopoGeo_AddLinestring, expected LINESTRING

+N1

+S1|f|

+S2|f|

 L2

-HS1|f|t

-HS2|f|t

 f

 


_______________________________________________
postgis-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/postgis-devel
Reply | Threaded
Open this post in threaded view
|

Re: topology pgsql 10 regression failures

Paul Ramsey-3
Look at the test that is failing, it has nothing to do w/ selectivity:

-- #3399
WITH g as (
select 'POLYGON((1 0, 0 1, 1 2, 2 1, 1 0))'::geometry as geom
),
n as (
select n from unnest(ARRAY[-1,0,1,10,100,1000]) n
),
pts as (
  select n,(st_dump(st_generatepoints(geom, n))).geom from g,n
)
select '#3399' as t, n, count(*) from
g, pts
where st_contains(g.geom, pts.geom)
group by n
ORDER BY n;

(Incidentally, works fine on OSX)

P



On Fri, May 26, 2017 at 10:35 AM, Regina Obe <[hidden email]> wrote:

I beat you to it J

 

https://trac.osgeo.org/postgis/ticket/3764

 

I'll try to fix when I get the chance.

 

BTW: For this error, are you seeing this one?

 

https://trac.osgeo.org/postgis/ticket/3759

 

 

/tmp/2.4.0dev_pg10_geos3.7.0dev_gdal2.1.3w64/test_89_diff)

-----------------------------------------------------------------------------

--- tickets_expected   2016-09-26 01:59:38 -0400

+++ /projects/postgis/tmp/2.4.0dev_pg10_geos3.7.0dev_gdal2.1.3w64/test_89_out        2017-05-25 15:15:09 -0400

@@ -285,7 +285,7 @@

#3375|GEOMETRYCOLLECTION(POINT(0 -7))

#3399|1|1

#3399|10|10

-#3399|100|100

+#3399|100|99

#3399|1000|1000

ERROR:  invalid KML representation

#3437a|5

-----------------------------------------------------------------------------

 

 

Do we go with float or float4.  If float4, I think you need to change the regression and also the pre-10 code.

 

the geometry regression in tickets caused by this change

 nd_stats = palloc(sizeof(float) * sslot.nnumbers);
 memcpy(nd_stats, sslot.numbers, sizeof(float) * sslot.nnumbers);

To:

 nd_stats = palloc(sizeof(float4) * sslot.nnumbers);
 memcpy(nd_stats, sslot.numbers, sizeof(float4) * sslot.nnumbers);

 

 

Thanks,

Regina

 

 

From: postgis-devel [mailto:[hidden email]] On Behalf Of Paul Ramsey
Sent: Friday, May 26, 2017 11:13 AM
To: PostGIS Development Discussion <[hidden email]>
Subject: [postgis-devel] topology pgsql 10 regression failures

 

Several failures for me (Darwin Kernel Version 15.6.0) right now in topology, for example, 

 

regress/st_simplify .. failed (diff expected obtained: /tmp/pgis_reg/test_26_diff)

 

This "invalid geometry type" shows up in a few of the other failures further down. Anyone seeing similar things w/ pgsql 10? 

 

--- regress/st_simplify_expected    2014-12-01 12:28:41.000000000 -0800

+++ /tmp/pgis_reg/test_26_out   2017-05-26 08:02:22.000000000 -0700

@@ -1,9 +1,8 @@

 t

 L1

-N2

-S1|f|t

-S2|f|t

+ERROR:  Invalid geometry type (POLYGON) passed to TopoGeo_AddLinestring, expected LINESTRING

+N1

+S1|f|

+S2|f|

 L2

-HS1|f|t

-HS2|f|t

 f

 


_______________________________________________
postgis-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/postgis-devel


_______________________________________________
postgis-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/postgis-devel
Reply | Threaded
Open this post in threaded view
|

Re: topology pgsql 10 regression failures

Regina Obe-2

Hmm mysteriously it's not failing on my PostgreSQL 10 anymore either.  So guess it wasn't what I thought it was.

 

I guess I'll just close that out unless it happens again.  Don't know what changed betwee the two revisions.

 

From: postgis-devel [mailto:[hidden email]] On Behalf Of Paul Ramsey
Sent: Friday, May 26, 2017 1:43 PM
To: PostGIS Development Discussion <[hidden email]>
Subject: Re: [postgis-devel] topology pgsql 10 regression failures

 

Look at the test that is failing, it has nothing to do w/ selectivity:

 

-- #3399

WITH g as (

select 'POLYGON((1 0, 0 1, 1 2, 2 1, 1 0))'::geometry as geom

),

n as (

select n from unnest(ARRAY[-1,0,1,10,100,1000]) n

),

pts as (

  select n,(st_dump(st_generatepoints(geom, n))).geom from g,n

)

select '#3399' as t, n, count(*) from

g, pts

where st_contains(g.geom, pts.geom)

group by n

ORDER BY n;

 

(Incidentally, works fine on OSX)


P

 

 

On Fri, May 26, 2017 at 10:35 AM, Regina Obe <[hidden email]> wrote:

I beat you to it J

 

https://trac.osgeo.org/postgis/ticket/3764

 

I'll try to fix when I get the chance.

 

BTW: For this error, are you seeing this one?

 

https://trac.osgeo.org/postgis/ticket/3759

 

 

/tmp/2.4.0dev_pg10_geos3.7.0dev_gdal2.1.3w64/test_89_diff)

-----------------------------------------------------------------------------

--- tickets_expected   2016-09-26 01:59:38 -0400

+++ /projects/postgis/tmp/2.4.0dev_pg10_geos3.7.0dev_gdal2.1.3w64/test_89_out        2017-05-25 15:15:09 -0400

@@ -285,7 +285,7 @@

#3375|GEOMETRYCOLLECTION(POINT(0 -7))

#3399|1|1

#3399|10|10

-#3399|100|100

+#3399|100|99

#3399|1000|1000

ERROR:  invalid KML representation

#3437a|5

-----------------------------------------------------------------------------

 

 

Do we go with float or float4.  If float4, I think you need to change the regression and also the pre-10 code.

 

the geometry regression in tickets caused by this change

 nd_stats = palloc(sizeof(float) * sslot.nnumbers);
 memcpy(nd_stats, sslot.numbers, sizeof(float) * sslot.nnumbers);

To:

 nd_stats = palloc(sizeof(float4) * sslot.nnumbers);
 memcpy(nd_stats, sslot.numbers, sizeof(float4) * sslot.nnumbers);

 

 

Thanks,

Regina

 

 

From: postgis-devel [mailto:[hidden email]] On Behalf Of Paul Ramsey
Sent: Friday, May 26, 2017 11:13 AM
To: PostGIS Development Discussion <[hidden email]>
Subject: [postgis-devel] topology pgsql 10 regression failures

 

Several failures for me (Darwin Kernel Version 15.6.0) right now in topology, for example, 

 

regress/st_simplify .. failed (diff expected obtained: /tmp/pgis_reg/test_26_diff)

 

This "invalid geometry type" shows up in a few of the other failures further down. Anyone seeing similar things w/ pgsql 10? 

 

--- regress/st_simplify_expected    2014-12-01 12:28:41.000000000 -0800

+++ /tmp/pgis_reg/test_26_out   2017-05-26 08:02:22.000000000 -0700

@@ -1,9 +1,8 @@

 t

 L1

-N2

-S1|f|t

-S2|f|t

+ERROR:  Invalid geometry type (POLYGON) passed to TopoGeo_AddLinestring, expected LINESTRING

+N1

+S1|f|

+S2|f|

 L2

-HS1|f|t

-HS2|f|t

 f

 


_______________________________________________
postgis-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/postgis-devel

 


_______________________________________________
postgis-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/postgis-devel